T345056: dark mode support #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikerabbit
reviewed
Mar 19, 2024
src/init.js
Outdated
| init( getColorScheme() ); | ||
|
|
||
| // Re-init as needed as the color scheme changes | ||
| observeDarkModePluginActivation( ( scheme ) => { |
There was a problem hiding this comment.
You could further simplify by passing the function directly instead of creating a lambda with the same signature as the function.
src/link/colorScheme.js
Outdated
| const attNameWPDarkModePlugin = 'data-wp-dark-mode-active'; | ||
|
|
||
| const isWPDarkModePluginActive = () => { | ||
| const htmlTag = document.documentElement; |
There was a problem hiding this comment.
No real use for the htmlTag variable
src/link/colorScheme.js
Outdated
| } | ||
| } ); | ||
|
|
||
| observer.observe( htmlTag, { attributes: true } ); |
There was a problem hiding this comment.
No real use for the htmlTag variable
hueitan
reviewed
Mar 22, 2024
hueitan
reviewed
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T345056